Skip to content

Use datatype Sensitive to prevent credentials leaks.#284

Closed
camilo-schoeningh-sociomantic wants to merge 1 commit into
puppetlabs:mainfrom
camilo-schoeningh-sociomantic:show_diff
Closed

Use datatype Sensitive to prevent credentials leaks.#284
camilo-schoeningh-sociomantic wants to merge 1 commit into
puppetlabs:mainfrom
camilo-schoeningh-sociomantic:show_diff

Conversation

@camilo-schoeningh-sociomantic

Copy link
Copy Markdown

No description provided.

@camilo-schoeningh-sociomantic camilo-schoeningh-sociomantic force-pushed the show_diff branch 4 times, most recently from caa356a to 453e34d Compare August 9, 2018 10:22
@austb

austb commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

I believe this might be better served by using the Sensitive data type. Let me know if that doesn't cover your use case, I may be missing something.

@camilo-schoeningh-sociomantic camilo-schoeningh-sociomantic changed the title Add show_diff parameter to prevent credentials leaks. Use datatype Sensitive to prevent credentials leaks. Aug 10, 2018
@camilo-schoeningh-sociomantic

Copy link
Copy Markdown
Author

@austb Cool! I missed that type. 👍

@camilo-schoeningh-sociomantic

Copy link
Copy Markdown
Author

The pr is updated.

@binford2k

binford2k commented May 16, 2019

Copy link
Copy Markdown
Contributor

Looks like tests are failing on this. Think you could address that @camilo-schoeningh-sociomantic?

       error during compilation: Evaluation Error: Error while evaluating a Resource
Statement, Evaluation Error: Left match operand must result in a String value. 
Got a Sensitive. (file: /home/travis/build/puppetlabs/puppetlabs-puppetdb/spec/fixtures/modules/postgresql/manifests/server/role.pp,
line: 127, column: 10) (file: /home/travis/build/puppetlabs/puppetlabs-
puppetdb/spec/fixtures/modules/postgresql/manifests/server/db.pp, line: 41) 
on node travis-job-cf78c5e3-7fbd-42e7-ab4f-fcf405004c05.c.travis-ci-prod-2.internal

@vchepkov

Copy link
Copy Markdown

It's just Sensitive, not Sensitive[String]

@gfa gfa mentioned this pull request Dec 22, 2020
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@h0tw1r3

h0tw1r3 commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

superseded by #331

@h0tw1r3 h0tw1r3 closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants