Use datatype Sensitive to prevent credentials leaks.#284
Closed
camilo-schoeningh-sociomantic wants to merge 1 commit into
Closed
Use datatype Sensitive to prevent credentials leaks.#284camilo-schoeningh-sociomantic wants to merge 1 commit into
camilo-schoeningh-sociomantic wants to merge 1 commit into
Conversation
caa356a to
453e34d
Compare
Contributor
|
I believe this might be better served by using the Sensitive data type. Let me know if that doesn't cover your use case, I may be missing something. |
453e34d to
87d0da5
Compare
Author
|
@austb Cool! I missed that type. 👍 |
Author
|
The pr is updated. |
87d0da5 to
3e2ca7b
Compare
Contributor
|
Looks like tests are failing on this. Think you could address that @camilo-schoeningh-sociomantic? |
|
It's just Sensitive, not Sensitive[String] |
|
|
Contributor
|
superseded by #331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.