(PDB-4092) Use vardir prefix for DLO path#285
Merged
Zak-Kent merged 1 commit intoSep 19, 2018
Conversation
austb
force-pushed
the
bug/master/pdb-4092/fix_hardcoded_dlo_path
branch
2 times, most recently
from
September 19, 2018 17:23
435d244 to
36b7b58
Compare
Previously, the DLO path was hardcoded in with its default value. This means that when attempting to clean a DLO store on a system using a non-default location for vardir, the puppetdb module would attempt to remove a directory that was not actually the DLO store (if it existed at all). Now, in accordance with how puppetdb selects the DLO store location, the puppetdb module will use `<vardir>/stockpile/discard/` as the DLO location.
austb
force-pushed
the
bug/master/pdb-4092/fix_hardcoded_dlo_path
branch
from
September 19, 2018 17:28
36b7b58 to
8078672
Compare
Contributor
|
LGTM, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the DLO path was hardcoded in with its default value. This
means that when attempting to clean a DLO store on a system using a
non-default location for vardir, the puppetdb module would attempt to
remove a directory that was not actually the DLO store (if it existed at
all).
Now, in accordance with how puppetdb selects the DLO store location, the
puppetdb module will use
<vardir>/stockpile/discard/as the DLOlocation.