Add a puppetdb_version fact with PuppetDB version#404
Merged
Conversation
The code changes add a new Facter fact called `puppetdb_version` that retrieves the version of PuppetDB installed on the system. It uses the `puppetdb --version` command to fetch the version and returns it as a fact value.
bastelfreak
reviewed
May 3, 2024
tuxmea
approved these changes
May 3, 2024
bastelfreak
approved these changes
May 3, 2024
puppetdb_version fact with PuppetDB version
smortex
approved these changes
May 3, 2024
|
Release v8.1.0 is broken for some people because of this. diff --git a/puppet/3rd-party-modules/puppetdb/lib/facter/puppetdb_version.rb b/puppet/3rd-party-modules/puppetdb/lib/facter/puppetdb_version.rb
index b04fb26ce..f75847652 100644
--- a/puppet/3rd-party-modules/puppetdb/lib/facter/puppetdb_version.rb
+++ b/puppet/3rd-party-modules/puppetdb/lib/facter/puppetdb_version.rb
@@ -2,7 +2,7 @@ Facter.add(:puppetdb_version) do
confine { Facter::Util::Resolution.which('puppetdb') }
setcode do
- output = Facter::Core::Execution.execute('puppetdb --version')
- output.split(':').last.strip
+ output = Facter::Core::Execution.execute('puppetdb version')
+ output.split('=').last.strip
end
end |
Collaborator
On Debian (AIO packages) and FreeBSD (packages built from Puppetlabs tarballs), I get: What did you install? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code changes add a new Facter fact called
puppetdb_versionthat retrieves the version of PuppetDB installed on the system. It uses thepuppetdb --versioncommand to fetch the version and returns it as a fact value.