Extend fact to not fail on debian packages#416
Conversation
Signed-off-by: Robert Waffen <rwaffen@gmail.com>
Signed-off-by: Robert Waffen <rwaffen@gmail.com>
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
- use Facter-functions Signed-off-by: Robert Waffen <rwaffen@gmail.com>
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
I really don't like this: it really stands as a packaging issue, and with the lifecycles of Debian releases we will have to carry this cruft for years… 😭
I added in-line notes, I think it is not as reliable as expected as it is now, but not being able to test this because of the missing Debian 12 packages from Puppetlabs do not help 😭.
- just report nil if command fails Signed-off-by: Robert Waffen <rwaffen@gmail.com>
|
i'll drop my efforts on solving this. its hard to get a testing environment for me. and the packages are completly not like the puppetlabs ones. this is a puppetlabs repo, so we handle puppetlabs packages with puppetlabs commands. if commands fail, report nil and exit. |
rwaffen
changed the title
|
I think this is valid, if someone cares about packages for other distributions they can add support for it. |
3 participants
i tried to get around the debian package differences and report a version also if this package is used. sadly somehow i didnt get
puppetdb versionrunning on my ubuntu testbox. so i tried to get the version from the package itself if it is not the puppetlabs one.fixes: #413