Add support for enabling puppetdb report processor#64
Conversation
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/51/) |
There was a problem hiding this comment.
This looks like an accidental whitespace change.
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/51/) |
|
@nicklewis yeah I think there was a tab in there that was showing up weird in my editor. I fixed all of those lines to use regular spaces and squashed a commit. Thanks |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/53/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/53/) |
There was a problem hiding this comment.
We keep copying this non-standard puppet doc header ... this is the style we should follow: http://docs.puppetlabs.com/guides/style_guide.html#puppet-doc but we probably need to do this everywhere as well. Its just that running this kind of header through rdoc makes it look terrible. Not a big deal of course, just thought I'd mention it.
There was a problem hiding this comment.
@kbarber is it the missing equals signs that you're referring to?
There was a problem hiding this comment.
No I mean the entire comment for the class.
There was a problem hiding this comment.
OK, but I'm only seeing minor differences between what you linked to and what's in this code. Namely: equals signs for headers, asterisks around parameter names... that's pretty much it?
There was a problem hiding this comment.
@cprice-puppet yeah thats about right, names of header sections as well are different (for example 'actions' could just be in the main description, and its 'examples' instead of sample usage). The parameters section renders differently using the format in the style guide also. While it looks like small differences, the difference in rendering makes it more presentable when put through the 'puppet doc' tool. Its not a big deal like I said, I'm happy to do a cleanup of all of this later if you like - getting all the classes, since I'm the one being pedantic :-).
|
This looks good, although we need:
|
There was a problem hiding this comment.
You didn't close the 'let' here.
There was a problem hiding this comment.
aha! thx. kind of surprised that didn't throw an error.
Add docs to readme, add basic rspec-puppet tests for new report_processor class, and fix broken rspec-system test.
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build finished. (Status: FAILURE, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/55/) |
|
retest this please |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/57/) |
|
Merged build finished. (Status: FAILURE, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/57/) |
|
retest this please |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/58/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/58/) |
…ling-report-processor Add support for enabling puppetdb report processor
5 participants
No description provided.