Allow puppetdb conn validation when ssl is disabled#68
Conversation
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/63/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb-system/63/) |
|
this patch is fundamentally flawed atm, b/c the validation uses the same port that it used to configure puppet. I need validation to be able to use the http port and for the master to still be confgured to use the https port. I may just update the patch so that it only updates the type/provider code so that I can just create my own custom validator in my own manifest. |
for my use case, I am not able to validate the ssl endpoint b/c I am creating my puppet certificates during my puppet run, so they are not available to the http get request. This patch adds a new resource parameter to the puppetdb_conn_validator that allows it to make a non-ssl connection. This allows me to declare my own http only resource that I can use to verify the puppetdb connection.
|
patch updated. |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb/65/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-puppetdb/65/) |
Allow puppetdb conn validation when ssl is disabled
4 participants
the puppetdb module allows the usage of https to
be disabled, but the connection validation resource
did not support the ability to verify non https
connections.
This patch introduces a new resource parameter
use_ssl which defaults to true (thus not changing
the current behavior). When set to false, the
connection validation occurs using regular http.