Non namespaced ensure_packages function behaviour changed in 9.0.0
#1374
Labels
Comments
alexjfisher
added a commit
to alexjfisher/puppetlabs-stdlib
that referenced
this issue
Jun 15, 2023
Make the `ensure_packages` shim an Internal function and pass scope to the namespaced version so as to not change the behaviour of where packages are contained. When the function was first ported to the new API, it was discussed that the existing behaviour might not be 'correct', but changing it would be a breaking change that might have consequences for many users. In namespacing the function in 9.0.0 we accidentally created a situation where the namespaced version worked as before, but the non-namespaced version, (the shim), now behaved differently. Fixes puppetlabs#1374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
As originally discussed in #1365 the behaviour of
ensure_packagesis subtly different depending on whether the namespaced or non-namespaced version is called.Expected Behavior
Package resources created by the function should be identically 'contained' whether they were created via the namespaced or non-namespaced function shim.
Additional Context
This issue supercedes #1365 where 2 separate issues are discussed and conflated.
A fix for this specific issue has been submitted in #1366
The text was updated successfully, but these errors were encountered: