faraday: allow latest versions#144
Closed
bastelfreak wants to merge 2 commits into
Closed
Conversation
latest faraday is required because: beaker -> beaker-abs -> vmfloaty and at least in beaker we need the github changelog generator gem and that requires faraday 1.x
bastelfreak
added a commit
to bastelfreak/beaker-abs
that referenced
this pull request
Jul 11, 2021
This is required to pull in the latest vmfloaty release with in turn allow the latest faraday (hopefully). See puppetlabs/vmfloaty#144 for details.
this is required to allow latest faraday
genebean
suggested changes
Jul 12, 2021
genebean
left a comment
genebean
left a comment
Contributor
There was a problem hiding this comment.
Please adjust this to some kind of bounded version instead of the new open ended ones shown here.
Contributor
|
@bastelfreak I am fairly sure that updating faraday and webmock is going to require some updating to tests too as I think there are breaking changes in newer versions. |
Contributor
|
If I'm grokking the versions correctly, #145 has handled this. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latest faraday is required because:
beaker -> beaker-abs -> vmfloaty
and at least in beaker we need the github changelog generator gem and
that requires faraday 1.x
Status
[Ready for Merge | In Progress | ???]
Description
FIXME
Related Issues
Todos
Reviewers
@puppetlabs/dio
@highb
@briancain