change urls in docs to use example.net/.com#50
Merged
Conversation
Prior to this commit, the docs and vmfloaty.yml.example file used a variety of live domains (mycompany.net, alternate.net). This commit changes those to example.net and example.com which are IANA-managed Reserved Domains. This will reduce the chance that any credentials could be harvested if a user executes the example commands without changing the domains.
demophoon
approved these changes
Apr 9, 2019
Contributor
|
Thanks @steveax for the updates! Hopefully not too much traffic was sent to those live domains. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the docs and vmfloaty.yml.example file used
a variety of live domains (mycompany.net, alternate.net). This commit
changes those to example.net and example.com which are IANA-managed
Reserved Domains. This will reduce the chance that any credentials
could be harvested if a user executes the example commands without
changing the domains.
Status
[Ready for Merge | In Progress | ???]
Description
FIXME
Related Issues
Todos
Reviewers
@demophoon
@briancain