Skip to content

Update docs#69

Merged
highb merged 1 commit into
masterfrom
docs-update
Jul 2, 2020
Merged

Update docs#69
highb merged 1 commit into
masterfrom
docs-update

Conversation

@genebean

@genebean genebean commented Jul 2, 2020

Copy link
Copy Markdown
Contributor

This chane updates docs to reflect that ownership has moved to the DIO team at Puppet. It also includes some formatting changes.

Comment thread vmfloaty.gemspec Outdated
s.version = Vmfloaty::VERSION
s.authors = ['Brian Cain']
s.email = ['brianccain@gmail.com']
s.authors = ['Puppet']

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I'd prefer to still be the author here since I wrote it :p Feel free to update the email though to include puppet, but I'd rather not erase the fact that I authored this project 😄

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, Brian wrote this and we should continue to credit him in the gemspec. Please update this to an array with both Brian and Puppet, @genebean.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @genebean 🙏

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll push an update as soon as my internet gets unbusted

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good now

Comment thread vmfloaty.gemspec Outdated
s.authors = ['Brian Cain']
s.email = ['brianccain@gmail.com']
s.authors = ['Puppet']
s.email = ['dio-gems@puppet.com']

@briancain briancain Jul 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s.email = ['dio-gems@puppet.com']
s.email = ['brianccain@gmail.com', 'dio-gems@puppet.com']

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be good now

Comment thread CODEOWNERS
This chane updates docs to reflect that ownership has moved to the DIO
team at Puppet. It also includes some formatting changes.
@genebean

genebean commented Jul 2, 2020

Copy link
Copy Markdown
Contributor Author

@briancain & @highb I think I have made all requested changes and then some :)

@highb

highb commented Jul 2, 2020

Copy link
Copy Markdown
Contributor

Aw, nice idea on the "Special Thanks" section. 😄 This looks good to me; @briancain any additional feedback?

@briancain

Copy link
Copy Markdown
Contributor

Yeah! Looks good to me. Thanks for the special thanks section ❤️

@highb highb merged commit 2de284f into master Jul 2, 2020
@highb highb deleted the docs-update branch July 2, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants