(maint) Fix using ABS service without a .vmfloaty.yml file#88
Merged
mattkirby merged 1 commit intoAug 20, 2020
Conversation
Author
|
With current vmfloaty trying to use ABS and no config file fails: Note in the stack trace on line 2, we're using pooler.rb, where we should be using abs.rb. With this PR I can now checkout a vm with ABS: |
briancain
suggested changes
Aug 20, 2020
If you do not use a config file, and define everything on the command line, previously the service always defaulted to vmpooler. Even if you requested ABS. This PR fixes that, now we'll see if the config has no service defined and we defined on the command line a service, we'll use that service.
664ee47 to
7015348
Compare
mattkirby
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you do not use a config file, and define everything on the command line,
previously the service always defaulted to vmpooler. Even if you requested ABS.
This PR fixes that, now we'll see if the config has no service defined and we
defined on the command line a service, we'll use that service.
Reviewers
@puppetlabs/dio
@highb
@briancain