Skip to content

(RE-15124) Initial implementation#1

Merged
yachub merged 26 commits into
mainfrom
initial-implementation
Apr 18, 2023
Merged

(RE-15124) Initial implementation#1
yachub merged 26 commits into
mainfrom
initial-implementation

Conversation

@yachub

@yachub yachub commented Jan 30, 2023 •
edited
Loading

Copy link
Copy Markdown

Creates a DNS plugin for GCP.

Depends on puppetlabs/vmpooler#551

@yachub yachub mentioned this pull request Feb 15, 2023
Merged
@yachub yachub changed the title Initial implementation (RE-15124) Initial implementation Feb 15, 2023
@yachub yachub mentioned this pull request Feb 23, 2023
Merged
@yachub yachub changed the title (RE-15124) Initial implementation [WIP] (RE-15124) Initial implementation Feb 28, 2023
@yachub yachub changed the title [WIP] (RE-15124) Initial implementation (RE-15124) Initial implementation Feb 28, 2023
@yachub yachub changed the title (RE-15124) Initial implementation [WIP] (RE-15124) Initial implementation Feb 28, 2023
@yachub yachub changed the title [WIP] (RE-15124) Initial implementation (RE-15124) Initial implementation Mar 7, 2023
@yachub yachub changed the title (RE-15124) Initial implementation [WIP] (RE-15124) Initial implementation Mar 7, 2023
genebean
genebean suggested changes Mar 22, 2023
View reviewed changes
Comment thread .github_changelog_generator
Comment thread .jrubyrc
Comment thread .rubocop.yml
Comment thread CHANGELOG.md Outdated
Comment thread Gemfile Outdated
Comment thread spec/gcp_helper.rb Outdated
Comment thread spec/spec_helper.rb
Comment thread spec/unit/dns/gcp_spec.rb
Comment thread vmpooler-dns-gcp.gemspec Outdated
Comment thread vmpooler-dns-gcp.gemspec Outdated
@yachub yachub added the enhancement New feature or request label Mar 28, 2023
@yachub yachub force-pushed the initial-implementation branch from 46668c7 to c4640fc Compare March 28, 2023 22:13
@yachub yachub force-pushed the initial-implementation branch 2 times, most recently from 2abfa86 to 1fdc7da Compare April 17, 2023 13:40
@yachub yachub force-pushed the initial-implementation branch from 1fdc7da to 5f47d64 Compare April 17, 2023 13:56
@yachub yachub marked this pull request as ready for review April 17, 2023 14:05
@yachub yachub requested a review from a team as a code owner April 17, 2023 14:05
@yachub yachub changed the title [WIP] (RE-15124) Initial implementation (RE-15124) Initial implementation Apr 17, 2023
genebean
genebean reviewed Apr 18, 2023
View reviewed changes
Comment thread .jrubyrc
genebean
genebean approved these changes Apr 18, 2023
View reviewed changes
Comment thread .rubocop.yml
Comment thread Gemfile.lock Outdated
@yachub yachub force-pushed the initial-implementation branch from 5f47d64 to 3df8183 Compare April 18, 2023 16:22
@yachub yachub merged commit fd04885 into main Apr 18, 2023
@yachub yachub deleted the initial-implementation branch April 18, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaac-jha isaac-jha isaac-jha approved these changes
+1 more reviewer
@genebean genebean genebean approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yachub @genebean @isaac-jha