(maint) Add rubocop and allow failures in Travis CI#183
Conversation
| cli = RuboCop::CLI.new | ||
| exit_code = cli.run(%w(--display-cop-names --format simple)) | ||
| raise "RuboCop detected offenses" if exit_code != 0 | ||
| end |
There was a problem hiding this comment.
What if I told you that Rubocop has Rake shims to help you out here?
From https://github.com/mckern/vanagon/blob/master/Rakefile:
desc 'Run RuboCop'
RuboCop::RakeTask.new(:rubocop) do |task|
task.options << '--display-cop-names'
endThat'll give you:
mckern@flexo vanagon (git:master) $ bundle exec rake -T | grep rubo
rake rubocop # Run RuboCop
rake rubocop:auto_correct # Auto-correct RuboCop offenses
mckern@flexo vanagon (git:master) $
| gem 'rspec', '>= 3.2' | ||
| gem 'simplecov', '>= 0.11.2' | ||
| gem 'yarjuf', '>= 2.0' | ||
| gem "rubocop", :platforms => [:ruby] |
There was a problem hiding this comment.
Maybe add a comment about Rubocop being A-OK if we transition to Jruby 9000 but for now it's MRI only?
|
Here's a neat Rubocop trick that can help keep 28 files inspected, 1534 offenses detected
Created .rubocop_todo.yml.
Run `rubocop --config .rubocop_todo.yml`, or add `inherit_from: .rubocop_todo.yml` in a .rubocop.yml file.
mckern@flexo vmpooler (git:master) $ rubocop --auto-gen-config --exclude-limit 100
<--- snip a LOT of warnings and failures --->
Run `rubocop --config .rubocop_todo.yml`, or add `inherit_from: .rubocop_todo.yml` in a .rubocop.yml file.
mckern@flexo vmpooler (git:master) $ rubocop --config .rubocop_todo.yml
Inspecting 28 files
..............C.............
Offenses:
lib/vmpooler/vsphere_helper.rb:398:9: C: Use the return of the conditional for variable assignment and comparison.
if child.name == snapshotname ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
28 files inspected, 1 offense detected
mckern@flexo vmpooler (git:master) $
|
|
@glennsarti you said I've got permissions to push up to your fork/branch? I might do so if you don't mind. |
|
@mckern Yes. by default (for a while now) all maintainers get write rights on the originating PR branches in the other person's repo (That's the |
glennsarti
force-pushed
the
add-rubocop
branch
from
959aa4a to
db4fa32
Compare
This commit adds the rubocop gem, a rubocop rake task and an initial rubocop configuration file in prepartion for using rubocop in CI. This commit also adds a rubocop todo file that exempts existing files from violations.
This commit adds rubocop checks to Travis for PR CI. Any rubocop failures will not fail the build yet. Fixes for rubocop violations will happen in later commits.
glennsarti
force-pushed
the
add-rubocop
branch
from
db4fa32 to
36310e3
Compare
|
Updated as per suggestions...but Travis seems to not be running on this PR :-( |
|
@glennsarti do you want this one in before the test additions? If so, merge it on in. |
|
Rubocop excludes specs dir so order should not matter. I'm generally against merging my own PRs but if +1 it, I'm happy. |
|
Yeah, don't merge your own PRs. |
3 participants
This PR adds the rubocop gem, a rubocop rake task and an initial rubocop
configuration file in prepartion for using rubocop in CI.
This PR adds rubocop checks to Travis for PR CI. Any rubocop failures will
not fail the build yet. Fixes for rubocop violations will happen in later
commits.