(maint) Fix rubocop violations #208
Merged
Merged
Conversation
This commit fixes minor rubocopy violations in eleven source files. Minor violations are those that include formatting, single quotes, and recently added classes.
This commit adds the following exceptions: - Style/EmptyMethod Methods which are empty are typically supposed to not spread over two lines however this is a matter of readability and should not be considered a violation - Metrics/BlockNesting Due to a legacy codebase there are instances where the block depth is quite high. Ignore these violations for the time being.
Quite a few rubocop violations have been resolved. This commit updates the rubocop todo file to reflect this.
Previously the Style/WordArray cop was crashing in the following fil: lib/vmpooler/api/helpers.rb This commit disables this cop until the root cause can be determined.
mattkirby
approved these changes
Mar 21, 2017
underscorgan
approved these changes
Mar 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes minor rubocopy violations in eleven source files. Minor
violations are those that include formatting, single quotes, and recently added
classes.
This commit adds the following rubocop exceptions:
Methods which are empty are typically supposed to not spread over two lines
however this is a matter of readability and should not be considered a
violation
Due to a legacy codebase there are instances where the block depth is quite
high. Ignore these violations for the time being.
This commit updates the
rubocop todo file to reflect this.
Previously the Style/WordArray cop was crashing in the following file:
lib/vmpooler/api/helpers.rb
This commit disables this cop until the root cause can be determined.