(GH-213) Remove use of private _connection method#224
Merged
shrug merged 1 commit intoJun 20, 2017
Conversation
Previosuly in find_vmdks in vsphere_helper it uses the call vmdk_datastore._connection to get the underlying connection, however this is already available as function parameter. This commit removes this bad code and the associated test fixtures.
glennsarti
force-pushed
the
gh-213-remove-underscore-connection
branch
from
b23175f to
3a4df79
Compare
sbeaulie
approved these changes
Jun 16, 2017
sbeaulie
approved these changes
Jun 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previosuly in find_vmdks in vsphere_helper it uses the call
vmdk_datastore._connection to get the underlying connection, however this is
already available as function parameter. This commit removes this bad code and
the associated test fixtures.