Identify when ESXi host quickstats do not return#248
Merged
Conversation
demophoon
reviewed
Jan 9, 2018
|
|
||
| def memory_utilization_for(host) | ||
| memory_usage = host.summary.quickStats.overallMemoryUsage | ||
| rturn nil if memory_usage.nil? |
Contributor
|
I'm good with this change once the typo is fixed |
mattkirby
force-pushed
the
fix_nil_utilization
branch
from
807f631 to
493179b
Compare
Contributor
Author
|
Fixed the typo. |
This commit updates cpu_utilization_for and memory_utilization_for to detect when quickstats are not present. Without this change a nil result is transformed to 0, which is perceived as a host that has no utilization.
mattkirby
force-pushed
the
fix_nil_utilization
branch
from
493179b to
46b7484
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates cpu_utilization_for and memory_utilization_for to detect when quickstats are not present. Without this change a nil result is transformed to 0, which is perceived as a host that has no utilization.