Conversation
Before, we were already capturing this metric but we failed to ship it anywhere. This ships the appropriate metric as `time_to_ready_state` Dashboards can be found in grafana.
Contributor
Author
|
@mattkirby It didn't look like any spec tests needed to change for this since we are only testing if metrics are generally getting sent or not. |
sbeaulie
approved these changes
Jul 6, 2018
Contributor
|
Great! I know John O'Connor was looking to do some analysis of ready times for improvements to the windows images (like running sysprep part of the build) |
Contributor
|
Looks reasonable to me. We could possibly add some test coverage for this addition by ensuring that metrics receives the expected timing when testing the method here vmpooler/spec/unit/pool_manager_spec.rb Line 182 in 27c9ee7 |
move_pending_vm_to_ready call.
mattkirby
approved these changes
Jul 9, 2018
junebug-spencer
added a commit
that referenced
this pull request
Jul 10, 2018
mattkirby
pushed a commit
that referenced
this pull request
Jul 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we were already capturing this metric but we failed to ship
it anywhere. This ships the appropriate metric as
time_to_ready_stateDashboards can be created easily in grafana.