Fix interrupt bugs wrt bracket masking #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when we check interrupt status, we are not considering the bracket masking status. When we enter a masked state (`bracketCount > 0`), it should be impossible for an interrupt to terminate evaluation, but without the bracket check in CATCH, RESUME, and RELEASE, this is violated. * In a nested async generalBracket, the wrong handler is enqueued. Since we are in a masked state, it should be impossible for the `killed` branch to be invoked. However, if an interrupt occurs it is currently _always_ invoking `killed` when the branch is actually `completed`. * In a nested bracket, an interrupt will terminate evaluation of the inner bracket even though we are in a masked state. This can also happen with an inner `catch` in a masked state. We need to always consider the masked state (`bracketCount > 0`) when we discriminate the interrupt state. Fixes purescript-contrib#170
|
/cc @felixSchl |
|
For what it's worth we applied this change to a fairly large codebase without having witnessed any negative side effects so far, and the problem we saw is fixed. We'll be running with these changes from now on and report if anything comes up. Thank you for looking into this and fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we check interrupt status, we are not considering the
bracket masking status. When we enter a masked state (
bracketCount > 0),it should be impossible for an interrupt to terminate evaluation, but
without the bracket check in CATCH, RESUME, and RELEASE, this is
violated.
Since we are in a masked state, it should be impossible for the
killedbranch to be invoked. However, if an interrupt occurs it is currently
always invoking
killedwhen the branch is actuallycompleted.inner bracket even though we are in a masked state. This can also happen
with an inner
catchin a masked state.We need to always consider the masked state (
bracketCount > 0) when wediscriminate the interrupt state.
Fixes #170