Skip to content

Won't build with latest purescript-colors 4.3.0 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
metaleap opened this issue Nov 2, 2017 · 4 comments · Fixed by #76
Closed

Won't build with latest purescript-colors 4.3.0 #73

metaleap opened this issue Nov 2, 2017 · 4 comments · Fixed by #76

Comments

@metaleap
Copy link

metaleap commented Nov 2, 2017

using purs current master branch (prints --version as 0.11.6 dev build), attempting to pulp build build a project with purescript-css (got version 3.3.0 from Pursuit) in the deps (and insisting on purescript-colors 4.3.0) results in:

* Building project in /home/rox/c/ps/test-pscorefn-src
Compiling CSS.String
Compiling CSS.Property
Compiling CSS.Selector
Compiling CSS.Color
Error 1 of 2:

  at bower_components/purescript-css/src/CSS/Selector.purs line 25, column 8 - line 25, column 54
  
    Cannot derive a type class instance for
                                    
      Data.Generic.Generic Predicate
                                    
    since instances of this type class are not derivable.
    
    
  See https://github.com/purescript/documentation/blob/master/errors/CannotDerive.md for more information,
  or to contribute content related to this error.
  
Error 2 of 2:

  at bower_components/purescript-css/src/CSS/Property.purs line 20, column 8 - line 20, column 52
  
    Cannot derive a type class instance for
                                   
      Data.Generic.Generic Prefixed
                                   
    since instances of this type class are not derivable.
@metaleap metaleap changed the title Won't build with latest purescript-colors 4.3.0 --- while project is still alive, might wanna keep up with deps =) Won't build with latest purescript-colors 4.3.0 Nov 2, 2017
@garyb
Copy link
Member

garyb commented Nov 2, 2017

This is because current master doesn't allow deriving of the old Generic anymore rather than a dependency issue.

@metaleap
Copy link
Author

metaleap commented Nov 2, 2017

Ah of course. Yeah I'm running into this quite a bit right now as I'm going through everything-on-Pursuit =)

@vyorkin
Copy link
Collaborator

vyorkin commented Apr 25, 2018

Just thinking... does it make sense if I try and make a PR to use the generics-rep instead of generics? should be a pretty trivial change

@garyb
Copy link
Member

garyb commented Apr 25, 2018

Sure, or we can probably remove generics entirely - the need for deep generics isn't present anymore, so unless anything in here is being implemented with generics I don't think the instances are all that useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants