Skip to content

Remove purescript-generics, upgrade dependencies #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2018
Merged

Remove purescript-generics, upgrade dependencies #76

merged 1 commit into from
Jun 28, 2018

Conversation

vyorkin
Copy link
Collaborator

@vyorkin vyorkin commented May 2, 2018 •
edited
Loading

Should fix #73.
I had to manually implement Show type class in several cases

@CLAassistant
Copy link

CLAassistant commented May 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

vyorkin
vyorkin commented May 2, 2018
View reviewed changes
src/CSS/ListStyle/Image.purs Outdated

instance showListStyleImage :: Show ListStyleImage where
show = gShow
show (ListStyleImage url) = "(ListStyleImage \"" <> url <> "\")"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok that I use quotes here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easier (and more correct) to do:
"(ListStyleImage " <> show url <> ")"

as that will use the proper escapes for everything inside the string.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll squash the commits

@kritzcreek
Copy link
Contributor

We're probably going to assimilate this PR into a 0.12 PR (which might need a few more tweaks and more version bumps). Thanks for starting the work 👍

@vyorkin vyorkin force-pushed the feature/remove-generics branch from 2ad1b47 to 79ecea8 Compare May 2, 2018 15:30
@safareli
Copy link
Contributor

safareli commented May 3, 2018

Would be nice to add package-lock.json to .gitignore too

@vyorkin
Copy link
Collaborator Author

vyorkin commented May 3, 2018 •
edited
Loading

@safareli sure, but I thought it is intended to be committed, according to official docs (for the reasons mentioned there)

@vyorkin
Copy link
Collaborator Author

vyorkin commented May 8, 2018 •
edited
Loading

@safareli added 📦-lock.json to gitignore (but tbh I think it should be checked into VCS)

@vyorkin vyorkin force-pushed the feature/remove-generics branch from 03c0760 to 3b42db0 Compare June 28, 2018 15:22
@vyorkin vyorkin force-pushed the feature/remove-generics branch from 3b42db0 to 5c9ea29 Compare June 28, 2018 15:26
@vyorkin
Copy link
Collaborator Author

vyorkin commented Jun 28, 2018 •
edited
Loading

Rebased onto the latest master & squashed the commits

@kritzcreek
Copy link
Contributor

This looks good, thanks!

@kritzcreek kritzcreek merged commit 9e78699 into purescript-contrib:master Jun 28, 2018
@vyorkin vyorkin deleted the feature/remove-generics branch June 28, 2018 23:18
@kl0tl kl0tl mentioned this pull request Dec 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kritzcreek kritzcreek kritzcreek left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Won't build with latest purescript-colors 4.3.0
4 participants
@vyorkin @CLAassistant @kritzcreek @safareli