Skip to content

Update import for lookup's new location #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Update import for lookup's new location #129

merged 1 commit into from
Feb 5, 2021

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Part of purescript/purescript-profunctor#23

Consequence of purescript/purescript-foldable-traversable#131.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

CI will fail until fix here (purescript/purescript-foldable-traversable#133) is merged.

@JordanMartinez
Copy link
Contributor Author

Pretty sure CI is failing here because of a caching issue... Does that sound right?

@JordanMartinez
Copy link
Contributor Author

Ha! No, it's the packages.dhall file.

@JordanMartinez
Copy link
Contributor Author

Looks like I started this PR on a way outdated version of main.

@JordanMartinez
Copy link
Contributor Author

Nevermind... We have a sort of chicken-and-egg problem here... The prepare-0.14 package set does not yet include the updated dependency graphs (i.e. purescript/package-sets#807). Thus, when CI here attempts to build, it's using the dependency graph before we did the functors migration. To get this CI to pass, we have to merge purescript/package-sets#807 first.

@JordanMartinez JordanMartinez merged commit 3df165d into purescript-contrib:main Feb 5, 2021
@JordanMartinez JordanMartinez deleted the accountForFunctorMigration branch February 5, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants