Skip to content

Add text-overflow CSS property #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vyorkin
Copy link
Collaborator

@vyorkin vyorkin commented Jul 8, 2018

This PR adds only basic support for text-overflow (I believe only fade is missing), but should cover most use-cases of this property.

Resolves #96

data TextOverflow
= Clip
| Ellipsis
| Placeholder String
Copy link
Collaborator Author

@vyorkin vyorkin Jul 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't imagine a better name for this.

The <string> to be used to represent clipped text. The string is displayed inside the content area, shortening the size of the displayed text. If there is not enough space to display the string itself, it is clipped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom maybe?

@vyorkin vyorkin force-pushed the feature/text-overflow branch from e6a3fea to 49fefa0 Compare July 8, 2018 18:00
@vyorkin
Copy link
Collaborator Author

vyorkin commented Jul 8, 2018

Renamed placeholder -> custom, rebased

@vyorkin vyorkin force-pushed the feature/text-overflow branch from 49fefa0 to b957552 Compare July 8, 2018 21:01
@garyb garyb merged commit 2183565 into purescript-contrib:master Jul 9, 2018
@vyorkin vyorkin deleted the feature/text-overflow branch July 9, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants