Skip to content

manyIndex ParseError message #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jamesdbrock opened this issue Oct 17, 2022 · 0 comments · Fixed by #211
Closed

manyIndex ParseError message #210

jamesdbrock opened this issue Oct 17, 2022 · 0 comments · Fixed by #211

Comments

@jamesdbrock
Copy link
Member

jamesdbrock commented Oct 17, 2022 •
edited
Loading

manyIndex should return the parse error message of the phrase parser which failed instead of “Expected more phrases.”

That’s what replicateA does.

purescript-parsing/src/Parsing/Combinators.purs

Line 472 in f806ce6

fail "Expected more phrases"

jamesdbrock added a commit that referenced this issue Nov 9, 2022
@jamesdbrock
Better errors for manyIndex
e5b1543 
Return the parse error message of the phrase parser which failed
instead of “Expected more phrases.” Also how many phrases were expected.

#210
@jamesdbrock jamesdbrock mentioned this issue Nov 9, 2022
Merged
4 tasks
@jamesdbrock jamesdbrock linked a pull request Nov 9, 2022 that will close this issue
Better errors for manyIndex #211
Merged
4 tasks
jamesdbrock added a commit that referenced this issue Nov 9, 2022
@jamesdbrock
Better errors for manyIndex
5426932 
Return the parse error message of the phrase parser which failed
instead of “Expected more phrases.” Also how many phrases were expected.

#210
jamesdbrock added a commit that referenced this issue Nov 9, 2022
@jamesdbrock
Better errors for manyIndex
81b66a1 
Return the parse error message of the phrase parser which failed
instead of “Expected more phrases.” Also how many phrases were expected.

#210
jamesdbrock added a commit that referenced this issue Nov 9, 2022
@jamesdbrock
Better errors for manyIndex (#211)
2a49674 
Return the parse error message of the phrase parser which failed
instead of “Expected more phrases.” Also how many phrases were expected.

#210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better errors for manyIndex purescript-contrib/purescript-parsing
1 participant
@jamesdbrock