Skip to content

Fix warnings revealed by v0.14.1 PS release #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 21, 2021
Merged

Fix warnings revealed by v0.14.1 PS release #112

merged 6 commits into from
Apr 21, 2021

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Apr 19, 2021

Description of the change

Self-explanatory


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

I'm not sure how these warnings should be handled. I'm assuming we should export them?

[UnusedDeclaration] .spago/parsing/v6.0.0/src/Text/Parsing/Parser/Indent.purs:207:1

  207  indentBrackets p = withPos $ pure identity <-/> symbol "[" <+/> p <-/> symbol "]"
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Declaration indentBrackets was not used, and is not exported.

[UnusedDeclaration] .spago/parsing/v6.0.0/src/Text/Parsing/Parser/Indent.purs:211:1

  211  indentAngles p = withPos $ pure identity <-/> symbol "<" <+/> p <-/> symbol ">"
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Declaration indentAngles was not used, and is not exported.

[UnusedDeclaration] .spago/parsing/v6.0.0/src/Text/Parsing/Parser/Indent.purs:215:1

  215  indentBraces p = withPos $ pure identity <-/> symbol "{" <+/> p <-/> symbol "}"
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Declaration indentBraces was not used, and is not exported.

[UnusedDeclaration] .spago/parsing/v6.0.0/src/Text/Parsing/Parser/Indent.purs:219:1

  219  indentParens p = withPos $ pure identity <-/> symbol "(" <+/> p <-/> symbol ")"
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Declaration indentParens was not used, and is not exported.

CHANGELOG.md Outdated
Comment on lines 14 to 15
- Fix warnings found by v0.14.1 PS release (#112)
- Add dependencies whoes modules are used directly in source code (#112)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix warnings found by v0.14.1 PS release (#112)
- Add dependencies whoes modules are used directly in source code (#112)
- Removed unused names found by v0.14.1 PureScript release (#112 by @JordanMartinez)
- Installed dependencies directly imported into source code that were previously installed transitively (#112 by @JordanMartinez)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit

@thomashoneyman
Copy link
Contributor

@JordanMartinez I'm surprised those warnings aren't showing up in the CI build; shouldn't they cause it to fail if the compiler is warning on them?

Otherwise, we can decide whether we want to export those functions or remove them.

@JordanMartinez
Copy link
Contributor Author

@thomashoneyman CI isn't failing because it's still using v0.14.0. Once we update it to v0.14.1, it will fail.

@JordanMartinez
Copy link
Contributor Author

Latest commit exports those 4 unused/unexported functions.

@thomashoneyman thomashoneyman merged commit 982a957 into purescript-contrib:main Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants