-
Notifications
You must be signed in to change notification settings - Fork 51
Fix warnings revealed by v0.14.1 PS release #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings revealed by v0.14.1 PS release #112
Conversation
I'm not sure how these warnings should be handled. I'm assuming we should export them?
|
CHANGELOG.md
Outdated
- Fix warnings found by v0.14.1 PS release (#112) | ||
- Add dependencies whoes modules are used directly in source code (#112) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix warnings found by v0.14.1 PS release (#112) | |
- Add dependencies whoes modules are used directly in source code (#112) | |
- Removed unused names found by v0.14.1 PureScript release (#112 by @JordanMartinez) | |
- Installed dependencies directly imported into source code that were previously installed transitively (#112 by @JordanMartinez) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest commit
@JordanMartinez I'm surprised those warnings aren't showing up in the CI build; shouldn't they cause it to fail if the compiler is warning on them? Otherwise, we can decide whether we want to export those functions or remove them. |
@thomashoneyman CI isn't failing because it's still using |
Latest commit exports those 4 unused/unexported functions. |
Description of the change
Self-explanatory
Checklist: