Skip to content

Remove all *Rec combinators #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Breaking changes:
prevents a compiler error (i.e. `MixedAssociativityError`)
without causing issues with `<$>`.
- Rename module prefix from `Text.Parsing.Parser` to `Parsing` (#169 by @jamesdbrock)
- Remove all `*Rec` combinators (#173 by jamesdbrock)

New features:

Expand Down
12 changes: 4 additions & 8 deletions bench/Main.purs
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,8 @@ import StringParser.CodeUnits as StringParser.CodeUnits
string23 :: String
string23 = "23"

string23_2 :: String
string23_2 = fold $ replicate 2 string23

-- string23_10000 :: String
-- string23_10000 = fold $ replicate 10000 string23
string23_5000 :: String
string23_5000 = fold $ replicate 10000 string23

string23_500 :: String
string23_500 = fold $ replicate 500 string23
Expand All @@ -95,9 +92,6 @@ stringSkidoo = "skidoo"
stringSkidoo_2 :: String
stringSkidoo_2 = fold $ replicate 2 stringSkidoo

-- stringSkidoo_10000 :: String
-- stringSkidoo_10000 = fold $ replicate 10000 stringSkidoo

stringSkidoo_1000 :: String
stringSkidoo_1000 = fold $ replicate 1000 stringSkidoo

Expand Down Expand Up @@ -161,6 +155,8 @@ htmlTableWrap caption benchmark = do
main :: Effect Unit
main = do
log "<tr>"
htmlTableWrap "runParser parse23 5000" $ benchWith 50
$ \_ -> runParser string23_5000 parse23
htmlTableWrap "runParser parse23" $ benchWith 200
$ \_ -> runParser string23_500 parse23
htmlTableWrap "StringParser.runParser parse23Points" $ benchWith 20
Expand Down
Loading