Skip to content

Change MonadState instance #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2022
Merged

Change MonadState instance #187

merged 1 commit into from
Apr 18, 2022

Conversation

jamesdbrock
Copy link
Member

@jamesdbrock jamesdbrock commented Apr 16, 2022 •
edited
Loading

state refers to base monad instead of ParseState

Resolves #56

With this PR, users who stack a ParserT on a StateT base monad will call the MonadState members directly like get instead of needing to do lift <<< get.

To get the ParserT internal state, call getParserT instead of get.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@jamesdbrock
Change MonadState instance
ed85e62 
`state` refers to base monad instead of `ParseState`
@jamesdbrock jamesdbrock marked this pull request as ready for review April 17, 2022 02:44
@jamesdbrock jamesdbrock merged commit 0bcfeb4 into main Apr 18, 2022
@jamesdbrock jamesdbrock deleted the monadstate branch April 18, 2022 05:46
@JordanMartinez JordanMartinez mentioned this pull request May 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconsider alternative instance for Transformer typeclasses
1 participant
@jamesdbrock