Parsing.String.Replace #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdbrock
force-pushed
the
replace
branch
6 times, most recently
from
b085311 to
c8e3fa3
Compare
natefaubion
reviewed
Apr 18, 2022
| => (MonadRec m) | ||
| => String | ||
| -> ParserT String m a | ||
| -> m (Maybe (T3 String a String)) |
There was a problem hiding this comment.
Would a record be more appropriate rather than T3?
There was a problem hiding this comment.
Maybe so? Like if this returned m (Maybe ({ prefix :: String, cap :: a, suffix :: String}))?
I kind of like the positional prefix /\ cap /\ suffix syntax because the relationship between the three return values is positional.
jamesdbrock
force-pushed
the
replace
branch
3 times, most recently
from
55b1123 to
dbf9344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module Parsing.String.Replace
Copied from https://github.com/jamesdbrock/purescript-parsing-replace
Checklist: