Skip to content

Revert "Fix CodePoint.anyChar parser" #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Fix CodePoint.anyChar parser" #47

wants to merge 1 commit into from

Conversation

hdgarrood
Copy link
Contributor

Reverts #46. Sorry @rintcius, I'll open an issue explaining in a moment.

@hdgarrood
Copy link
Contributor Author

Actually never mind. I was going to say that anyChar should be able to split up a surrogate pair, because that's what a Char is (we should just provide alternatives and discourage its use), but on reflection that isn't possible with the CodePoints parsers as-is because the pos field counts code points. I also thought that this was going to have to be released as a breaking change, but it only affects parsers which were broken before (where anyChar was being used on an astral plane character), so I think releasing this as a patch-level change should be okay after all.

@hdgarrood hdgarrood closed this Oct 15, 2019
@hdgarrood hdgarrood deleted the revert-46-fix-codepoint-anychar branch October 15, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hdgarrood