Skip to content

Add assertions on consumption behavior to parser spec tests #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chtenb
Copy link
Member

@chtenb chtenb commented Sep 10, 2022

Description of the change
The consumption behavior of our parser functions feels under specified and under documented. I think we should pay some more attention to this, compare the consumption behaviors of other libraries and assert these behaviors in tests. See also the discussion in #95


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@garyb
Copy link
Member

garyb commented Sep 10, 2022

Seems like a good idea to me 👍 purescript-parsing would probably benefit from similar treatment too, we could compare any differences then for places they overlap, and hopefully eliminate them.

I'm also curious about the performance difference between the two these days. But that's another project entirely.

@jamesdbrock
Copy link
Member

It is definitely true in purescript-parsing also that “consumption behavior of our parser functions feels under specified and under documented.”

@srghma
Copy link
Member

srghma commented Sep 29, 2024

here https://youtu.be/LLkbzt4ms6M?t=1472 @jamesdbrock tells "no monad transformers -> faster"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants