Skip to content

Don't return empty object for unit #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

Don't return empty object for unit #40

merged 1 commit into from
Dec 10, 2020

Conversation

thomashoneyman
Copy link
Contributor

This change removes return {} from functions which return no useful value (Unit), for a small performance benefit.

@thomashoneyman thomashoneyman merged commit bee0b99 into master Dec 10, 2020
@thomashoneyman thomashoneyman deleted the no-empty-object-return branch December 10, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kl0tl kl0tl kl0tl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomashoneyman @kl0tl