Skip to content

Drop deprecated group' and empty #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Drop deprecated group' and empty #219

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0545ca3
Drop deprecated group' and empty
JordanMartinez Mar 17, 2022
deda6a5
Add changelog
JordanMartinez Mar 17, 2022
b245468
Drop redundant prim imports
JordanMartinez Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Notable changes to this project are documented in this file. The format is based

Breaking changes:
- Migrate FFI to ES modules (#218 by @kl0tl and @JordanMartinez)
- Drop deprecated `group'` and `empty` (#219 by @JordanMartinez)

New features:

Expand Down
5 changes: 0 additions & 5 deletions src/Data/Array.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ module Data.Array
, span
, group
, groupAll
, group'
, groupBy
, groupAllBy

Expand Down Expand Up @@ -983,10 +982,6 @@ group xs = groupBy eq xs
groupAll :: forall a. Ord a => Array a -> Array (NonEmptyArray a)
groupAll = groupAllBy compare

-- | Deprecated previous name of `groupAll`.
group' :: forall a. Warn (Text "'group\'' is deprecated, use 'groupAll' instead") => Ord a => Array a -> Array (NonEmptyArray a)
group' = groupAll

-- | Group equal, consecutive elements of an array into arrays, using the
-- | specified equivalence relation to determine equality.
-- |
Expand Down
5 changes: 0 additions & 5 deletions src/Data/Array/NonEmpty.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ module Data.Array.NonEmpty
, span
, group
, groupAll
, group'
, groupBy
, groupAllBy

Expand Down Expand Up @@ -424,10 +423,6 @@ group = unsafeAdapt $ A.group
groupAll :: forall a. Ord a => NonEmptyArray a -> NonEmptyArray (NonEmptyArray a)
groupAll = groupAllBy compare

-- | Deprecated previous name of `groupAll`.
group' :: forall a. Warn (Text "'group\'' is deprecated, use 'groupAll' instead") => Ord a => NonEmptyArray a -> NonEmptyArray (NonEmptyArray a)
group' = unsafeAdapt $ A.groupAll

-- | Group equal, consecutive elements of an array into arrays, using the
-- | specified equivalence relation to determine equality.
-- |
Expand Down
4 changes: 0 additions & 4 deletions src/Data/Array/ST.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ module Data.Array.ST
, run
, withArray
, new
, empty
, peek
, poke
, modify
Expand Down Expand Up @@ -80,9 +79,6 @@ foreign import unsafeThaw :: forall h a. Array a -> ST h (STArray h a)
-- | Create a new, empty mutable array.
foreign import new :: forall h a. ST h (STArray h a)

empty :: forall h a. Warn (Text "'Data.Array.ST.empty' is deprecated, use 'Data.Array.ST.new' instead") => ST h (STArray h a)
empty = new

-- | Create a mutable copy of an immutable array.
foreign import thaw :: forall h a. Array a -> ST h (STArray h a)

Expand Down