-
Notifications
You must be signed in to change notification settings - Fork 70
Update non-ST FFI to use Fn #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What is the motivation for this? Just to write more idiomatic JS in the FFI? Is this a change we're going to apply across core? |
Co-authored-by: Thomas Honeyman <[email protected]>
Here's my rationale:
|
@@ -18,6 +18,7 @@ | |||
"purescript-bifunctors": "^6.0.0", | |||
"purescript-control": "^6.0.0", | |||
"purescript-foldable-traversable": "^6.0.0", | |||
"purescript-functions": "^6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not considering this a relevant dependency change because this was already brought in transitively (but good we now have it listed)
Just as an FYI for changes like this, changing FFI calling conventions will potentially break optimizations. |
That is, if it's important for the core team (I'm not saying it is) to preserve optimizations in tools like backend-optimizer, it's important that we actually do follow up and verify the impact of these changes. |
Description of the change
Updates non-
ST
FFI to use uncurried functions viaFn
typesChecklist: