Skip to content

Add length to Data.Array.ST #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Add length to Data.Array.ST #239

merged 3 commits into from
Jan 17, 2023

Conversation

Blugatroff
Copy link
Contributor

@Blugatroff Blugatroff commented Jan 14, 2023

Description of the change

This PR adds length :: forall h a. STArray h a -> ST h Int to the Data.Array.ST module.
This was recently requested in #238 and i need it as well.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor

@garyb Can I get a second approval here?

@garyb
Copy link
Member

garyb commented Jan 16, 2023

I'd suggest we just export a foreign length without the lengthImpl? The Impl stuff is only needed if we're doing something like maybe-ifying an FFI operation.

Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JordanMartinez JordanMartinez merged commit 88fe038 into purescript:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants