Skip to content

Traversable1 and TraversableWithIndex #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Traversable1 and TraversableWithIndex #17

merged 1 commit into from
Oct 23, 2018

Conversation

MonoidMusician
Copy link
Contributor

No description provided.

@garyb
Copy link
Member

garyb commented Oct 23, 2018

Thanks!

@garyb
Copy link
Member

garyb commented Oct 23, 2018

Hmm, I wonder though... as an alternative, maybe these instances should use a constraint on the underlying type and use those instances instead? That's how a lot of the others are defined for Identity. 🤔

@MonoidMusician
Copy link
Contributor Author

Thanks for looking at this! I don’t know of a way to accomplish that, since the parameter is of Type, and the classes take Type -> Type ... maybe that would be possible for something like App f a, but still, I think it’s useful for Identity to literally be the identity functor in its own right, and not wholly transparent.

@garyb
Copy link
Member

garyb commented Oct 23, 2018

Ooh good point, yep. This looks good then!

@garyb garyb merged commit 1b7938a into purescript:master Oct 23, 2018
@MonoidMusician
Copy link
Contributor Author

Cool, thank you Gary :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants