Changelog updates since v4.1.0 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesfrain
commented
Jan 19, 2021
CHANGELOG.md
Outdated
|
|
||
| New features: | ||
|
|
||
| Bugfixes: | ||
| - Changed `Foldable1`'s `fold1` member to `foldl1` and `foldr1` (#21, #23) |
There was a problem hiding this comment.
Not sure if this is the correct summary. Also not sure if this is considered a bugfix.
There was a problem hiding this comment.
Yeah.... Not sure myself either. It's not a breaking change. I wouldn't say it's a bug fix either though because there wasn't a release that included the unchanged instance, so that it no longer worked and we needed to fix it in a separate release.
I think I would move this to "Other improvements" and say something like
Updated
Identity'sFoldable1instance to account for changes inFoldable1definition.
|
Other than my comment above, this looks good to me. |
thomashoneyman
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates the CHANGELOG in preparation for the upcoming release of this library.
Related: purescript/purescript#3985