Add Eq1 Ord1 to NonEmptyList LazyNonEmptyList #188
Conversation
|
CI shows that the Lazy version of this change fails to compile, but the non-Lazy version works fine. Don't know why. |
| @@ -211,6 +211,12 @@ derive instance newtypeNonEmptyList :: Newtype (NonEmptyList a) _ | |||
| derive newtype instance eqNonEmptyList :: Eq a => Eq (NonEmptyList a) | |||
| derive newtype instance ordNonEmptyList :: Ord a => Ord (NonEmptyList a) | |||
|
|
|||
| instance eq1NonEmptyList :: Eq1 NonEmptyList where | |||
| eq1 (NonEmptyList lhs) (NonEmptyList rhs) = eq1 lhs rhs | |||
There was a problem hiding this comment.
Was hoping this shorthand would work, but it does not:
eq1 = over NonEmptyList eq1
There was a problem hiding this comment.
I've seen a number of cases where omitting arguments in an instance doesn't work. But I think it's arguably better to include the arguments explicitly in any case.
There was a problem hiding this comment.
I'd argue that the shorthand version is better, since it protects you from making a mistake like this:
compare1 (NonEmptyList rhs) (NonEmptyList lhs) = compare1 lhs rhs
|
Should these changes be tested, and if so, I guess I should also add the same tests to the empty-able lists too? |
|
Actually let’s include the changelog updates in each PR please; the merge conflicts that would be introduced will all be very easy to fix. |
|
Thank you! |
Description of the change
Adds
Eq1andOrd1instances toNonEmptyListandLazyNonEmptyListFixes #186
Checklist: