Add/finish Ord instance for Records#180
Merged
garyb merged 1 commit intopurescript:masterfrom Jul 17, 2018
LiamGoodacre:feature/ord-record
Merged
Add/finish Ord instance for Records#180garyb merged 1 commit intopurescript:masterfrom LiamGoodacre:feature/ord-record
garyb merged 1 commit intopurescript:masterfrom
LiamGoodacre:feature/ord-record
Conversation
Member
|
I'm for it 👍 Anyone feel strongly against it for any reason? Speak now or forever hold your peas. |
Contributor
|
I’m slightly uneasy about the potential for people to use a type synonym for a particular record type and expect its Ord instance to use the order written in the type synonym declaration, as was discussed somewhere a while ago (I can’t be bothered to hunt for it right now). This is a fairly minor objection though, and instance is clearly useful so 👍 |
|
@hdgarrood I don't think that's any different than people using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176
It's very annoying that we didn't make this instance, especially when it disrupts upgrading in some cases: removal-of-deriving-for-records-in-generics-rep#3.