Remove deprecated 'unsafeCompare'#257
Merged
JordanMartinez merged 2 commits intopurescript:masterfrom Jan 13, 2021
JordanMartinez:removeUnsafeCompare
Merged
Remove deprecated 'unsafeCompare'#257JordanMartinez merged 2 commits intopurescript:masterfrom JordanMartinez:removeUnsafeCompare
JordanMartinez merged 2 commits intopurescript:masterfrom
JordanMartinez:removeUnsafeCompare
Conversation
Contributor
Author
|
We should probably merge this after #256 so I can add this to the changelog. |
hdgarrood
approved these changes
Jan 13, 2021
Contributor
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
I have no preference for merging before or after the changelog PR but just wanted to give the approval so that you can merge when you’re ready.
turlando
pushed a commit
to purescm/purescript-prelude
that referenced
this pull request
Sep 3, 2021
* Remove deprecated unsafeCompare * Update changelog to include this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #256