Fix warnings revealed by v0.14.1 PS release#262
Merged
JordanMartinez merged 2 commits intopurescript:masterfrom Apr 18, 2021
JordanMartinez:fixNewWarnings
Merged
Fix warnings revealed by v0.14.1 PS release#262JordanMartinez merged 2 commits intopurescript:masterfrom JordanMartinez:fixNewWarnings
JordanMartinez merged 2 commits intopurescript:masterfrom
JordanMartinez:fixNewWarnings
Conversation
Contributor
Author
|
Do we need another approval on this before it can be merged? |
Contributor
|
We don't need another approval, because you're on the core team so you count too. |
Contributor
Author
|
Great! That'll make this easier to do. |
Contributor
|
@thomashoneyman it looks to me like CI is using 0.14.0 here - do you know if/when it'll switch to 0.14.1? Is some kind of manual intervention required in setup-purescript? |
Member
|
setup-purescript updates nightly, so by tomorrow it’ll be updated. However we can always manually update the versions file in that repo and it’ll take effect immediately. |
Contributor
|
Ah I see - good to know, thanks. |
turlando
pushed a commit
to purescm/purescript-prelude
that referenced
this pull request
Sep 3, 2021
* Fix warnings revealed by v0.14.1 PS release * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
The
v0.14.1PS release now reports warnings on more things. CI will fail due to these new warnings. This PR fixes those warnings.Backlinking to purescript/purescript#4071
Checklist: