Skip to content

Fix signum implementation #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 16, 2022
Merged

Fix signum implementation #280

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
95741d1
Fix signum implementation
JordanMartinez Feb 13, 2022
80447ea
Add changelog entry
JordanMartinez Feb 13, 2022
64119e5
Reimplement w/o 'otherwise'
JordanMartinez Feb 13, 2022
478203e
Apply suggestions from code review
JordanMartinez Mar 3, 2022
afa818b
Update src/Data/Ord.purs
JordanMartinez Mar 3, 2022
bab0a84
Adjust doc comment to use sized zeros rendering
JordanMartinez Mar 3, 2022
c9c20b0
Add test for signum
JordanMartinez Mar 3, 2022
c042347
Add missing period.
JordanMartinez Mar 3, 2022
ab1a78a
Ensure signum test functions correctly
JordanMartinez Mar 3, 2022
047c8a3
Do test via `show (1.0/zero)` with clarifying test
JordanMartinez Mar 3, 2022
c85d8eb
Merge remote-tracking branch 'origin/master' into fix-signum
JordanMartinez Mar 11, 2022
2c8a023
Merge branch 'master' into fix-signum
JordanMartinez Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/Test/Main.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module Test.Main where

import Prelude
import Data.HeytingAlgebra (ff, tt, implies)
import Data.Ord (abs)
import Data.Ord (abs, signum)
import Test.Data.Generic.Rep (testGenericRep)
import Test.Utils (AlmostEff, assert)

Expand All @@ -15,6 +15,7 @@ main = do
testIntDegree
testRecordInstances
testGenericRep
testSignum

foreign import testNumberShow :: (Number -> String) -> AlmostEff

Expand Down Expand Up @@ -151,3 +152,8 @@ testRecordInstances = do
assert "Record top" $
(top :: { a :: Boolean }).a
== top

testSignum :: AlmostEff
testSignum = do
assert "signum positive zero" $ signum 0.0 == 0.0
assert "signum negative zero" $ signum (-0.0) == (-0.0)
Copy link
Contributor

@hdgarrood hdgarrood Mar 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work unfortunately - positive zero compares equal to negative zero. Maybe try show-ing the result?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the test to

assert ("signum negative zero: " <> show (signum (-0.0))) $ show (signum (-0.0)) == "-0.0"

produces this error:

Error: signum negative zero: 0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And assert (show (-0.0)) $ false produces Error: 0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Object.is is a way to verify this.