Skip to content

Update to v0.14.0-rc3 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2020
Merged

Update to v0.14.0-rc3 #129

merged 2 commits into from
Nov 15, 2020

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Oct 23, 2020 •
edited
Loading

Blocked by nonempty, gen, arrays, and enums

@kl0tl
Copy link
Member

kl0tl commented Oct 24, 2020

We could replace some uses of unsafeCoerce by Safe.Coerce.coerce in the implementations of toNonEmptyString, fromNonEmptyString and liftS in Data.String.NonEmpty.CodePoints and Data.String.NonEmpty.CodeUnits.

Sadly we can’t remove the last unsafe coercions from Data.String.NonEmpty.CodeUnits.fromFoldable1 and Data.String.NonEmpty.Internal. joinWith implementations for the same reason we can’t do it either in arrays (see purescript/purescript-arrays#181 (comment)).

@JordanMartinez
Copy link
Contributor Author

CI builds. Need 1 more review.

@JordanMartinez JordanMartinez mentioned this pull request Nov 14, 2020
Closed
57 tasks
@thomashoneyman
Copy link
Member

Should we include @kl0tl’s suggestions in this PR or in a subsequent one?

@JordanMartinez
Copy link
Contributor Author

A subsequent one. This PR gets the library to compile, so I can get quickcheck and other libraries to compile. I'll dad a note in the 'core libs' issue to remind us to do that.

@JordanMartinez JordanMartinez merged commit cc98047 into purescript:master Nov 15, 2020
@JordanMartinez JordanMartinez deleted the updateTo14 branch November 15, 2020 15:02
This was referenced Nov 15, 2020
Closed
Merged
@toastal toastal mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JordanMartinez @kl0tl @thomashoneyman