Skip to content

Topic/free #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jun 3, 2014
Merged

Topic/free #4

merged 39 commits into from
Jun 3, 2014

Conversation

ethul
Copy link
Contributor

@ethul ethul commented May 29, 2014

I know that we are still working out purescript/purescript-free#6; however, I thought we could migrate the repo over to transformers, and continue work here. I can hold off on this if you like until purescript/purescript-free#6 is resolved, or if if looks okay, please feel free to merge this PR in. Either works for me.

@paf31
Copy link
Contributor

paf31 commented May 29, 2014

Looks good to me, thanks :)

But I'll wait until @garyb and @puffnfresh weigh in on this as well before I merge.

In terms of dependencies, I plan to fix scrap-your-markup, and I know there is mongodbf. Is there anything else? Edit: I forgot about tasks.

@ethul
Copy link
Contributor Author

ethul commented May 29, 2014

Welcome. Also, I think the dependencies you've listed are the current ones

@garyb
Copy link
Member

garyb commented May 29, 2014

Looks good to me also. 🆓

@paf31
Copy link
Contributor

paf31 commented Jun 3, 2014

Hi @ethul. Sorry that this got delayed, but it looks like it's out of date now with what's in the free repo. What do we need to move? And should we plan to deprecate/remove free once this is merged?

@ethul
Copy link
Contributor Author

ethul commented Jun 3, 2014

hi @paf31, everything should be in this PR. Granted I merged it from another branch, but all the code is there. The only difference in free on master is the version bump. Unless, did you notice something specific that is missing from the PR? Also, after this merge, we can definitely deprecate, then after a bit remove free does that work?

@paf31
Copy link
Contributor

paf31 commented Jun 3, 2014

Ah, I didn't see that you ported goEff etc. Thanks :)

paf31 added a commit that referenced this pull request Jun 3, 2014
@paf31 paf31 merged commit aaa86da into purescript:master Jun 3, 2014
@ethul
Copy link
Contributor Author

ethul commented Jun 3, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants