-
Notifications
You must be signed in to change notification settings - Fork 132
Fail upon encountering unrecognized fields in the config #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
864be87
0e6ccb2
440984e
2126309
f5665c0
cbde7e0
631f31e
c092b40
4ceab91
d83d89d
4036115
1194b32
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,6 @@ package: | |
bundle: | ||
type: "app" | ||
minify: true | ||
sourceMaps: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And immediately we have a winner! Turns out There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or not a bug? Technically this can be specified in extra args, as I did here, but this is asymmetry. Not sure what the overarching philosophy is here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great catch! Overarching philosophy is that we try to keep flags and config params as close to each other as possible. There are some notable exceptions, but this one is a bug: we should have a config parameter as well. |
||
module: Docs.Search.App | ||
outfile: "../../bin/docs-search-app.js" | ||
platform: browser | ||
|
@@ -47,3 +46,4 @@ package: | |
# The node module is also considered deprecated and recommends using the upstream npm package punycode. So its an easy swap-in. | ||
# The extra / at the end is how you tell node and esbuild to override a builtin node package with a user-space package. | ||
- "--alias:punycode=punycode/" | ||
- "--sourcemap" |
Uh oh!
There was an error while loading. Please reload this page.