New 'spago init --subpackage foo' option to initialize a sub-project within current workspace #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoikin
commented
Aug 30, 2024
…within current workspace
fsoikin
force-pushed
the
init-subpackage
branch
from
4016324 to
9a32078
Compare
|
@f-f is force-pushing a rebase on master ok? |
I mean, anything goes since we squash-merge everything. When I do it myself I always merge instead of rebasing because it makes it easier to deal with conflicts, but it doesn't matter in this case. |
f-f
reviewed
Sep 2, 2024
bin/src/Flags.purs
Outdated
| initMode = | ||
| (Init.InitSubpackage <$> subpackageName) | ||
| <|> (Init.InitWorkspace <$> maybePackageName) | ||
| <|> Prelude.pure (Init.InitWorkspace Nothing) |
There was a problem hiding this comment.
Why import Prelude qualified here? It's already an open import.
There was a problem hiding this comment.
Because there is a value named pure in this module. It's parsing the --pure flag.
Took me a few minutes to figure out :-)
There was a problem hiding this comment.
Oh no, how is it not issuing a warning? 🤔
Let's rename the flag to pureLockfile or something like that
f-f
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #1137
spago init --subpackage foocreates a new subdirectoryfooand initializes a project there with workspace-less config.spago init --subpackage foo --name baris disallowed.--subpackageis used together with--package-setand/or--use-solver, these options are ignored (obviously) and a warning is printed out.optparseconfig level, but decided it would be too unobvious.Checklist:
[ ] Added some example of the new feature to theREADME