Refactor trigger(Batch) and introduce sendToUser #329
Conversation
| } | ||
|
|
||
| // json_encode might return false on failure | ||
| if (!$data_encoded) { |
There was a problem hiding this comment.
nit you may wrap getting data_encoded in the separate function to increase readability
There was a problem hiding this comment.
This is copying from the previous implementation. So I'll leave it as is in this PR, but it could be done in a separate PR. There are some other long functions in this file.
| if (count($channel_values) == 1) { | ||
| $post_params['channel'] = $channel_values[0]; | ||
| } else { | ||
| $post_params['channels'] = $channel_values; | ||
| } |
There was a problem hiding this comment.
This is a backward breaking change. The payload has changed from being channel in case only one channel is supplied. This has always been channels no matter the number of channels provided.
Ref: #351
There was a problem hiding this comment.
I'm missing something. Can you help me understand how this breaks things for you? This payload is sent to the pusher server and it accepts both.
There was a problem hiding this comment.
You are right, this only applies to custom servers.
Description
Refactor trigger functions to reduce code duplication and introduce sendToUser functions
CHANGELOG