-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Compatibility with pv-terms #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm confused. The phrase "translation equations" implies that this is something more than a renaming. In any case, it would be helpful to see some examples. That might also help us prioritize.
Pieces.
I think it would be worthwhile to solicit feedback on the pvlib-python google group before we commit to anything. |
Agree with @wholmgren : in pieces and with caution. There are places where pvlib would be improved by making the variable names more consistent, but in many instances I don't see that pvlib would be improved by using names from pvterms. I also think it's premature to commit to pvterms compatibility, as pvterms has very limited vetting. |
Okay, for starters, there are two hopefully straightforward internal consistency issues to correct. Single diode Module parameters For both of these, I'd suggest to go with what we decided for pvterms. |
This will be a large project, but will greatly improve the internal consistency and portability of pvlib. We have been working on the pvterms project to unify parameter naming with the express intention of being applicable to pvlib. We can also modify pv-terms somewhat to make the transition more smooth for pvlib.
In developing other projects, I'm currently writing many translation equations to get from pvlib to the standard pv-terms scheme. How can we go about making modifications to pvlib? Should we do this in pieces, e.g. get all single diode model params into compliance as one effort, or should we aim for a full-scale renaming?
The text was updated successfully, but these errors were encountered: