Skip to content

Compatibility with pv-terms #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toddkarin opened this issue Jul 28, 2020 · 3 comments
Open

Compatibility with pv-terms #1012

toddkarin opened this issue Jul 28, 2020 · 3 comments

Comments

@toddkarin
Copy link

This will be a large project, but will greatly improve the internal consistency and portability of pvlib. We have been working on the pvterms project to unify parameter naming with the express intention of being applicable to pvlib. We can also modify pv-terms somewhat to make the transition more smooth for pvlib.

In developing other projects, I'm currently writing many translation equations to get from pvlib to the standard pv-terms scheme. How can we go about making modifications to pvlib? Should we do this in pieces, e.g. get all single diode model params into compliance as one effort, or should we aim for a full-scale renaming?

@wholmgren
Copy link
Member

wholmgren commented Jul 28, 2020

In developing other projects, I'm currently writing many translation equations to get from pvlib to the standard pv-terms scheme.

I'm confused. The phrase "translation equations" implies that this is something more than a renaming. In any case, it would be helpful to see some examples. That might also help us prioritize.

Should we do this in pieces, e.g. get all single diode model params into compliance as one effort, or should we aim for a full-scale renaming?

Pieces.

with the express intention of being applicable to pvlib.

I think it would be worthwhile to solicit feedback on the pvlib-python google group before we commit to anything.

@cwhanse
Copy link
Member

cwhanse commented Jul 28, 2020

Agree with @wholmgren : in pieces and with caution. There are places where pvlib would be improved by making the variable names more consistent, but in many instances I don't see that pvlib would be improved by using names from pvterms.

I also think it's premature to commit to pvterms compatibility, as pvterms has very limited vetting.

@toddkarin
Copy link
Author

toddkarin commented Jul 28, 2020

Okay, for starters, there are two hopefully straightforward internal consistency issues to correct.

Single diode
For single diode parameters, there are two conventions: e.g. photocurrent vs. I_L_ref. There's also an unnecessary use of both a_ref and nNsVth, instead of just choosing one scheme.

Module parameters
There's some inconsistency between v_oc, Voco, Bvoco , beta_voc, beta_oc and V_oc_ref . The best thing would be to use the same variables and style for all of these. However, I'd understand if you don't want to change the Sandia parameters for reference to the paper, but at least getting agreement non-Sandia parameters would be good.

For both of these, I'd suggest to go with what we decided for pvterms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants