Skip to content

change eta_m to module_efficiency #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue Mar 9, 2021 · 1 comment · Fixed by #1218
Closed

change eta_m to module_efficiency #1188

wholmgren opened this issue Mar 9, 2021 · 1 comment · Fixed by #1218
Labels
Milestone

Comments

@wholmgren
Copy link
Member

wholmgren commented Mar 9, 2021

temperature.noct_sam uses eta_m_ref to describe the module efficiency at reference conditions and temperature.pvsyst_cell uses eta_m to describe the module efficiency generically.

Just calling both of these module_efficiency would make the function signatures easily understandable by many more people. I'd be ok with module_efficiency_ref but I don't think that precision is very important.

I skimmed pvterms and didn't see a suggestion for this quantity.

temperature.noct_sam has not yet been released and it's just a positional argument, so changing the name is trivial. temperature.pvsyst_cell would need a deprecation cycle.

Originally discussed in #1177 (comment)

Assignment of milestone indicates that we will act on this or close it forever before 0.9 is released.

@wholmgren wholmgren added the api label Mar 9, 2021
@wholmgren wholmgren added this to the 0.9.0 milestone Mar 9, 2021
@cwhanse
Copy link
Member

cwhanse commented Mar 9, 2021

I support this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants