Skip to content

finishing issue-1188 #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

MichaelHopwood
Copy link
Contributor

  • Closes change eta_m to module_efficiency #1188
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

We conducted a global search and replaced all reference to eta_m and eta_m_ref with module_efficiency. However, we are not quite sure how to incorporate the deprecation cycle, as referred to in the original ticket. Additional guidance for this process will be appreciated.

@cwhanse
Copy link
Member

cwhanse commented May 7, 2021

@MichaelHopwood see #1218 maybe you could look at #1118?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change eta_m to module_efficiency
2 participants