Skip to content

Remove shadowed/unused kwargs from PVSystem methods #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wfvining opened this issue Dec 17, 2020 · 0 comments · Fixed by #1222
Closed

Remove shadowed/unused kwargs from PVSystem methods #1118

wfvining opened this issue Dec 17, 2020 · 0 comments · Fixed by #1222
Labels
api
Milestone
0.9.0

Comments

@wfvining
Copy link
Contributor

Describe the bug
calcparams_cec, calcparams_desoto, and sapm have a **kwargs parameter that is shadowed and therefore unused. It should be deprecated and removed.

Expected behavior
Users should get an error when they pass arbitrary/unexpected kwargs.

Additional context
In #1076 these args are completely unused (not just shadowed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

removed kwargs in calcparams_desoto, calcparams_cec, and sapm MichaelHopwood/pvlib-python
2 participants
@wfvining @wholmgren