-
Notifications
You must be signed in to change notification settings - Fork 1.1k
removed kwargs in calcparams_desoto, calcparams_cec, and sapm #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we want to remove these kwargs without deprecation? I am not opposed since I don't think it would hit many people and it would most likely be in code that can be fixed relatively easily. Depending on the decision about deprecation, the note in the whats new needs to move to breaking changes or to deprecations. |
I'm ok without deprecation, I doubt that kwargs was used much for these PVSystem methods. Agree with @wholmgren about the placement of the whatsnew note. |
Thanks @wholmgren and @cwhanse for the feedback. I moved the whatsnew note to the breaking changes section. |
Thanks @wholmgren and @kanderso-nrel for the feedback! I updated the whatsnew file per your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @MichaelHopwood!
thanks @MichaelHopwood! |
Removed the **kwargs parameters from
calcparams_cec
,calcparams_desoto
, andsapm
. Python automatically returns aTypeError
upon user input of unexpected parameters.Tests addedUpdates entries todocs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).